Raise error in tools.costs when a technology is assigned a reduction rate for which it does not have value #270
Draft
measrainsey wants to merge 3 commits intomainfrom
Draft
Raise error in tools.costs when a technology is assigned a reduction rate for which it does not have value #270measrainsey wants to merge 3 commits intomainfrom
tools.costs when a technology is assigned a reduction rate for which it does not have value #270measrainsey wants to merge 3 commits intomainfrom
Conversation
measrainsey
changed the title
tools.coststools.costs when a technology is assigned a reduction rate for which it does not have value
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
=======================================
- Coverage 78.3% 77.4% -0.9%
=======================================
Files 217 217
Lines 16851 16854 +3
=======================================
- Hits 13196 13049 -147
- Misses 3655 3805 +150
🚀 New features to boost your workflow:
|
measrainsey
force-pushed
the
mm/costs/add-error
branch
from
52989ea to
c2223c3
Compare
khaeru
force-pushed
the
mm/costs/add-error
branch
from
c2223c3 to
04e5544
Compare
khaeru
force-pushed
the
mm/costs/add-error
branch
from
04e5544 to
fdd2dfd
Compare
khaeru
force-pushed
the
mm/costs/add-error
branch
from
fdd2dfd to
ecf2597
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to add an error in the costs tool in instances where a technology has a reduction category that is missing data
This issue came up in #235 (see @khaeru's comment here), where a technology was missing a reduction rate category in
cost_reduction.csvthat other technologies had. In this case, it didn't matter too much as that missing cost reduction category was never specified for that technology in thescenarios_reduction.csv. However, a hypothetical was brought up: what happens if a technology is assigned a reduction category for a scenario, but said reduction category does not exist for said technology?I have added a few lines to check for these instances and if they exist, the tool should raise an error.
How to review
For @khaeru and/or @glatterf42 : Read the diff and note that the CI checks all pass.
PR checklist